Add gingko conformance timeout #2474
Conversation
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
/test ls |
|
@CecileRobertMichon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts |
|
/assign @marosset @sedefsavas @mboersma |
|
/cherry-pick release-1.4 |
|
@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.3 |
|
@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -5,3 +5,4 @@ ginkgo.progress: true | |||
| ginkgo.slowSpecThreshold: 120.0 | |||
| ginkgo.trace: true | |||
| ginkgo.v: true | |||
| ginkgo.timeout: 10800s | |||
There was a problem hiding this comment.
Can this be a more human-readable value, e.g. : 3h? (I don't know, I've been looking at Gingko docs but it's unclear to me.)
There was a problem hiding this comment.
Good question, I think so
-timeout=24h (or some other, suitable value) must be passed because the default timeout was reduced from 24h to 1h
let's try
There was a problem hiding this comment.
changed to 3h
k8s-ci-robot
added
the
lgtm
|
LGTM Should we be setting this for the Windows e2e tests that don't use ci-conformance.sh? |
CecileRobertMichon
force-pushed
the
fix-conformance-timeout
branch
from
b1e6caa
to
23d2081
Compare
k8s-ci-robot
removed
the
lgtm
|
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts |
Not right away, it should be done in #2466 when we switch CAPZ e2e to use the v2 CLI. For now it's still using v1. This is only changing conformance because the conformance suite runs the k/k test suite which already got updated to ginkgo v2. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@CecileRobertMichon: new pull request created: #2475 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@CecileRobertMichon: new pull request created: #2476 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sorry missed this notification: kubernetes-sigs/windows-testing#336 |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
After kubernetes/kubernetes#109111 in the Kubernetes repo, conformance tests started failing with timeout.
(slack thread for details)
This PR sets the timeout due to this change:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: