🌱 E2e: Bump clusterctl upgrade to start from v0.7.2 #1568
Conversation
- Bump clusterctl upgrade v0.7 test to start from v0.7.2 - Sync and bump cert-manager version in Makefile and e2e_conf.yaml - Sync CAPI container tags in Makefile and e2e_conf.yaml
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
size/S
| // Note: There isn't really anything fixing this to the v0.6 release. The test will | ||
| // simply pick the latest release with the correct contract from the E2EConfig, as seen here | ||
| // https://github.com/kubernetes-sigs/cluster-api/blob/3abb9089485f51d46054096c17ccb8b59f0f7331/test/e2e/clusterctl_upgrade.go#L265 | ||
| // When new minor releases are added (with the same contract) we will need to work on this | ||
| // if we want to continue testing v0.6. |
There was a problem hiding this comment.
This comment is no longer relevant. It is now possible to set the exact version to use for each provider and we are using this below in the test.
|
looks good ,wait for CI fix then will lgtm |
| docker pull gcr.io/k8s-staging-cluster-api/cluster-api-controller:v1.3.0 | ||
| docker pull gcr.io/k8s-staging-cluster-api/kubeadm-bootstrap-controller:v1.3.0 | ||
| docker pull gcr.io/k8s-staging-cluster-api/kubeadm-control-plane-controller:v1.3.0 | ||
| docker pull quay.io/jetstack/cert-manager-cainjector:v1.8.2 | ||
| docker pull quay.io/jetstack/cert-manager-webhook:v1.8.2 | ||
| docker pull quay.io/jetstack/cert-manager-controller:v1.8.2 |
There was a problem hiding this comment.
These were all out of sync with the e2e_conf.yaml, meaning that we were pulling one version and then trying to load another version into the kind cluster. The result was basically that we pulled multiple images multiple times. Tests should be slightly faster when these are in sync.
|
/retest These look unrelated? |
|
/retest let's try again |
|
It is some issue with prow itself. Tracked here: kubernetes/test-infra#29622 |
|
/retest |
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold