-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ adjust loadbalancer wait.Backoff #853
✨ adjust loadbalancer wait.Backoff #853
Conversation
Hi @chrischdi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I don't get the sparkles part, sorry :D |
/retitle ✨ adjust loadbalancer wait.Backoff It's not that hard :) P.S. just learned yesterday that both versions are okay for the release note generation |
/approve Very nice fix, should bring down the cluster reconciliation time quite a bit. (we had min. 30s wait per lb resources, which explains why it took so long) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@sbueringer : needs ok-to-test ;-) |
/ok-to-test You should apply to org member ship :) You have to check if the prereqs are fullfilled: #853 (comment) |
I assume you would sponsor me ;-) I'd still need a second sponsor to fulfill the requirements |
Yup exactly. I think make a few more PRs/Issues here or in cloud-provider-openstack and it should be fine according to the guidelines. Either @jichenjc or someone from cloud-provider-openstack will probably sponsor you. (WDYT @jichenjc ?) |
yes, I will do , my pleasure :) |
/lgtm |
What this PR does / why we need it:
Adjusts the wait.Backoff definition which is used in
waitForLoadBalancerActive
andwaitForListener
.With the current implementation the controller waits 30s also for tasks which are pretty fast like adding a load balancer member.
The old values did result in:
9*30s = 270s
The new values result in a exponential backoff:
273s
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold