-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Add some events and refactor related to instance #862
🏃 Add some events and refactor related to instance #862
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hidekazuna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
I did take a look on the PR, I hope this helps :-)
return trunk, nil | ||
} | ||
|
||
func replaceAllAttributestag(is *Service, object runtime.Object, trunkID string, tags []string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this func is specific to trunks? If so I think we should add some context to the function name, otherwise we could rename trunkID
to resourceID
like it is named in the ReplaceAll
func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to express the context by function naming replaceAllAttributestag
and argument name trunkID
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this would be a good pattern. If there later is a code review and someone does a replaceAllAttributestag(is, object, port.ID, i.Tags)
the context would be gone.
Also:
If we keep the name, it should be called AttributesTags
(upper-case T, and s), just the package name is all lowercase and inside the gophercloud package it is also called AttributesTags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrischdi So you want to rename to replaceAllAttributesTagsOfTrunk
or something?
I agree with upper-case T. This function name should start with small letter, since this function is not public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer something like that, however I would be also ok with replaceAllAttributesTag
if this is still your favourite 😌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed replaceAllAttributestag
to replaceAllAttributesTags
. Sorry forgot to say ending with small s.
@chrischdi please ping me when you're happy, then I'll also take a look :) |
160620c
to
6908731
Compare
/lgtm @sbueringer ping |
@chrischdi: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@hidekazuna Imho you can squash + merge now |
Add events: - Delete attachinterface, trunk, and port - Create port and trunk - Replace all attributestags
5d2cbf9
to
8bdc74e
Compare
@sbueringer Thanks, Let's squash and merge. Please lgtm again. |
/lgtm |
@hidekazuna: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
What this PR does / why we need it:
Add events
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold