Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardware reservation support for machine #137

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Hardware reservation support for machine #137

merged 2 commits into from
Jun 24, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Jun 23, 2020

No description provided.

jhead-slg and others added 2 commits June 23, 2020 14:47
@jhead-slg
add hardware reservation id support
135106b
Add support for single reservation ID
e567596 
Fixed #133
Fixed #134

This PR adds a field to the PacketMachine in order to use a reservation
ID for device creation.
@gianarb gianarb requested a review from deitch June 23, 2020 16:58
deitch
deitch reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, see the comment

docs/concepts/machine.md Show resolved Hide resolved
@gianarb gianarb merged commit 8b269d2 into master Jun 24, 2020
@cprivitere cprivitere deleted the add/hardwareReservationID branch July 19, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch deitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gianarb @deitch @jhead-slg