Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes HA with multi control plane #142

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Kubernetes HA with multi control plane #142

merged 1 commit into from
Jul 2, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Jul 1, 2020

This PR enables support for KubeadmControlPlane. It allows multi
control-plane supports.

The default template creates a 6 node cluster with 3 control planes and
3 workers.

I would like to merge this PR with the functionality it contains, I created another issue to track the elastic-ip assign: #141

@gianarb gianarb requested a review from deitch July 1, 2020 13:22
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2020
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos/doc changes, and some questions.

controllers/packetcluster_controller.go Outdated Show resolved Hide resolved
controllers/packetcluster_controller.go Outdated Show resolved Hide resolved
controllers/packetcluster_controller.go Outdated Show resolved Hide resolved
controllers/packetmachine_controller.go Show resolved Hide resolved
docs/concepts/cluster.md Outdated Show resolved Hide resolved
pkg/cloud/packet/client.go Show resolved Hide resolved
pkg/cloud/packet/client.go Outdated Show resolved Hide resolved
scripts/generate-cluster.sh Show resolved Hide resolved
This PR enables support for KubeadmControlPlane. It allows to get multi
control-plane supports.

The default template creates a 6 node cluster with 3 control planes and
3 workers.
@gianarb gianarb requested a review from deitch July 2, 2020 07:30
@deitch
Copy link
Contributor

deitch commented Jul 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 620918f into kubernetes-sigs:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants