Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support use of pxeurls in machine provisioning #143

Merged
merged 1 commit into from
Jul 6, 2020
Merged

feat: support use of pxeurls in machine provisioning #143

merged 1 commit into from
Jul 6, 2020

Conversation

rsmitty
Copy link
Contributor

@rsmitty rsmitty commented Jul 2, 2020 •
edited

This PR will add a new field to packetmachine that allows for the
passing of a pxe url string. If present, we check that the OS is also
set to "custom_ipxe" so that we can fail early.

Will close #131
Related issue #118

Signed-off-by: Spencer Smith robertspencersmith@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @rsmitty!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-packet 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-packet has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2020
@rsmitty
Copy link
Contributor Author

rsmitty commented Jul 2, 2020

/assign @gianarb @deitch

@rsmitty rsmitty force-pushed the master branch 2 times, most recently from 35849c3 to 65caefb Compare July 2, 2020 15:49
@deitch
Copy link
Contributor

deitch commented Jul 3, 2020

A few things.

  • This is nice. I do think you need to regenerate the code if this changes is to go through.
  • Why have a separate field, and not just have the OS field respect a URL? This would avoid the potential conflict between OS and IPXEUrl fields. On the other hand, if this is how the Packet OS already works, might as well live with it.

@rsmitty
feat: support use of pxeurls in machine provisioning
ab57ab9 
This PR will add a new field to packetmachine that allows for the
passing of a pxe url string. If present, we check that the OS is also
set to "custom_ipxe" so that we can fail early.

Signed-off-by: Spencer Smith <robertspencersmith@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2020
@rsmitty
Copy link
Contributor Author

rsmitty commented Jul 3, 2020 •
edited

@deitch I ran make generate fmt vet crds and amended my commit. Anything else I need to do there? Looks like the CRDs have been updated and whatnot. The fmt also caught a few other fields and formatted them just FYI.

I'll defer to what you all want on using the OS field vs. having a distinct PXEUrl field. But as a data point, they're two unique fields in packngo, as well as in the UI:
Screen Shot 2020-07-03 at 10 37 24 AM

@deitch
Copy link
Contributor

deitch commented Jul 3, 2020

I was afraid of that. If they’re two distinct fields in the core api and packngo, then let’s leave it as is.

@deitch
Copy link
Contributor

deitch commented Jul 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2020
@gianarb
Copy link
Contributor

gianarb commented Jul 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianarb, rsmitty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 115debb into kubernetes-sigs:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsmith928 jacobsmith928 Awaiting requested review from jacobsmith928

@mrmrcoleman mrmrcoleman Awaiting requested review from mrmrcoleman

Assignees

@deitch deitch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for custom ipxe boot
4 participants
@rsmitty @k8s-ci-robot @deitch @gianarb