Swapoff command does not get persisted #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
sig/cluster-lifecycle
k8s-ci-robot
added
approved
As you know kubelet requires swap to be off in order to run successfully. I was using the command `swapoff -a` but it does not work after a reboot because the swap turns on again. This PR fixes the issue modifying the fstab file.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deitch, gianarb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This definitely is good and should be done, but you might also want to check that it isn't enable in systemd |
|
Technically I tried and for ubuntu this works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you know kubelet requires swap to be off in order to run
successfully.
I was using the command
swapoff -abut it does not work after areboot because the swap turns on again.
This PR fixes the issue by modifying the fstab file.
/assign @deitch
/kind bug