Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more verbose tag to mark the elastic IP #150

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Use a more verbose tag to mark the elastic IP #150

merged 1 commit into from
Jul 9, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Jul 9, 2020

/assign @deitch

@gianarb gianarb added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2020
@deitch
Copy link
Contributor

deitch commented Jul 9, 2020

Just two requests.

  1. Can you pull the creation of the tag into a separate func in the same file? So that we don't have the same hard-coded text and formatting in 2 places, and maybe later three, and maybe four, etc.?
  2. Can you use fmt.Sprintf() rather than adding the strings together with +? It makes it easier to see what part does what

@deitch
Copy link
Contributor

deitch commented Jul 9, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deitch, gianarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gianarb gianarb merged commit 053d864 into kubernetes-sigs:master Jul 9, 2020
@gianarb gianarb deleted the fix/new-tag-for-eip branch July 9, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch Awaiting requested review from deitch

@mrmrcoleman mrmrcoleman Awaiting requested review from mrmrcoleman

Assignees

@deitch deitch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gianarb @deitch @k8s-ci-robot