Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach ccm what it needs to look after the control plane endpoint #154

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Teach ccm what it needs to look after the control plane endpoint #154

merged 1 commit into from
Jul 15, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Jul 14, 2020

One of the Packet CCM responsability is to check the status of the
Control Plane Endpoint (an elastic ip) keeping it assigned to an healthy
control plane.

In order to do that it needs to know the key=pair used to tag the
elastic ip at creation phase. This PR pass this information to CCM via
Kubernetes Secret

One of the Packet CCM responsability is to check the status of the
Control Plane Endpoint (an elastic ip) keeping it assigned to an healthy
control plane.

In order to do that it needs to know the key=pair used to tag the
elastic ip at creation phase. This PR pass this information to CCM via
Kubernetes Secret
@gianarb gianarb requested a review from deitch July 14, 2020 15:51
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 14, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2020
@deitch
Copy link
Contributor

deitch commented Jul 15, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deitch, gianarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deitch
Copy link
Contributor

deitch commented Jul 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit fc452e7 into kubernetes-sigs:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants