Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The addresses do not contains the right value but a Go obj #158

Merged
merged 1 commit into from
Jul 28, 2020
Merged

The addresses do not contains the right value but a Go obj #158

merged 1 commit into from
Jul 28, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Jul 28, 2020

When converting the IPs from the device to kubernetes machine I didn't
render the right content (just the IP) but the entire Go object.

Fixed #157

/kind bug
/assign @deitch

When converting the IPs from the device to kubernetes machine I didn't
render the right content (just the IP) but the entire Go object.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2020
@gianarb gianarb requested a review from deitch July 28, 2020 09:11
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2020
@deitch
Copy link
Contributor

deitch commented Jul 28, 2020

/approve

@deitch
Copy link
Contributor

deitch commented Jul 28, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deitch, gianarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit c48b5fd into kubernetes-sigs:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make status.addresses JSON values
3 participants