Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module path to sigs.k8s.io/cluster-api-provider-packet #165

Merged
merged 3 commits into from
Aug 2, 2020
Merged

Update module path to sigs.k8s.io/cluster-api-provider-packet #165

merged 3 commits into from
Aug 2, 2020

Conversation

displague
Copy link
Member

@displague displague commented Aug 2, 2020 •
edited

In this PR:

  • package name was updated to sigs.k8s.io/cluster-api-provider-packet
  • go mod tidy was run
  • README badges were added (some referring to the new package name which won't work until after this is merged)
  • golanglint-ci linter warnings were corrected (unused packageName, ineffectual assignment)
  • Link was added to https://doc.crds.dev/github.com/kubernetes-sigs/cluster-api-provider-packet/ when discussing the PacketMachine spec

There are still references to packethost/cluster-api-provider-packet in the context of the Docker repo.

There are still references to kubernetes-sigs/cluster-api-provider-packet in the context of Github issues, releases, and workflows.

Closes #164

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 2, 2020
@displague displague changed the title Module path Update module path to sigs.k8s.io/cluster-api-provider-packet Aug 2, 2020
@deitch
Copy link
Contributor

deitch commented Aug 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2020
@deitch
Copy link
Contributor

deitch commented Aug 2, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deitch, displague

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 09c2adf into kubernetes-sigs:master Aug 2, 2020
@displague displague mentioned this pull request Aug 31, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianarb gianarb Awaiting requested review from gianarb

@mrmrcoleman mrmrcoleman Awaiting requested review from mrmrcoleman

Assignees

@deitch deitch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module path should be sigs.k8s.io/cluster-api-provider-packet
3 participants
@displague @deitch @k8s-ci-robot