Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 clusterctl init fail because manager does not use a canonical image name #185

Merged
merged 1 commit into from
Sep 10, 2020
Merged

🐛 clusterctl init fail because manager does not use a canonical image name #185

merged 1 commit into from
Sep 10, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Sep 10, 2020

Probably there is a new check that prevents clusterctl to work if an
the image does not follow the canonical naming convention.

This PR should fix this issue and it should make clusterctl init working
again.

fixed #184

clusterctl init fail because manager does not use a canonical image name
af6256a 
Probably there is a new check that prevent clusterctl to work if an
image does not follow the canonical naming convention.

This PR should fix this issue and it should make `clusterctl init` working
again.
@gianarb gianarb added the kind/bug Categorizes issue or PR as related to a bug. label Sep 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2020
cpanato
cpanato approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit d808029 into kubernetes-sigs:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@deitch deitch Awaiting requested review from deitch

@detiber detiber Awaiting requested review from detiber

@jacobsmith928 jacobsmith928 Awaiting requested review from jacobsmith928

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clusterctl init fails with "repository name must be canonical"
3 participants
@gianarb @k8s-ci-robot @cpanato