Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 escape / defer interpolation of TRIMMED/RESOLVED variables to runtime #196

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

rawkode
Copy link
Contributor

@rawkode rawkode commented Oct 28, 2020

What this PR does / why we need it:

The envsubst needs us to escape the variables that won't exist at template render time with $$

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2020
@rawkode
Copy link
Contributor Author

rawkode commented Oct 28, 2020

/assign @detiber

@detiber
Copy link
Member

detiber commented Oct 28, 2020

/lgtm
testing this change locally as well

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@displague
Copy link
Member

I ran into the same problem when running clusterctl config through the quickstart.

I assumed I could set TRIMMED_KUBERNETES_VERSION and RESOLVED_KUBERNETES_VERSION to v1.18.2, and I did, and this lead to Equinix Metal devices being provisioned. The problem was that kubectl and related tools were not installed.

These variables should have been set to 1.18.2 and 1.18.2-00 respectively.

This PR looks like it will fix that.

@gianarb
Copy link
Contributor

gianarb commented Oct 28, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianarb, rawkode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit c56c057 into kubernetes-sigs:master Oct 28, 2020
@rawkode rawkode deleted the fix/interpolate-defer branch October 28, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants