Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*sparkles* Cluster Resource Set #202

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Conversation

detiber
Copy link
Member

@detiber detiber commented Nov 9, 2020

What this PR does / why we need it:

  • Adds a cluster template that uses ClusterResourceSet for CNI deployment
  • Adds some defaults

To test this out, you will need to:

  • Set EXP_CLUSTER_RESOURCE_SET=true when running clusterctl init
  • Use --from to point to the template when running clusterctl config, if the cluster-template-crs.yaml file was attached to a release, then it would be possible to use --flavor=crs rather than --from

The template can be tested with the currently released images

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 9, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 9, 2020
@detiber detiber changed the title [WIP] *sparkles* Cluster Resource Set *sparkles* Cluster Resource Set Nov 12, 2020
@detiber detiber marked this pull request as ready for review November 12, 2020 18:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2020
@detiber
Copy link
Member Author

detiber commented Nov 12, 2020

/assign @rawkode

@k8s-ci-robot
Copy link
Contributor

@detiber: GitHub didn't allow me to assign the following users: rawkode.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @rawkode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, rawkode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gianarb
Copy link
Contributor

gianarb commented Nov 13, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2ccb41b into kubernetes-sigs:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants