Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ templates/cluster-template.yaml: consistently don't use sudo #221

Merged
merged 1 commit into from
Dec 15, 2020
Merged

✨ templates/cluster-template.yaml: consistently don't use sudo #221

merged 1 commit into from
Dec 15, 2020

Conversation

invidian
Copy link
Member

What this PR does / why we need it:

Other commands which are executed are also privileged, so using sudo
shouldn't be needed.

This is nice to enhance the consistency.

Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io

@invidian
templates/cluster-template.yaml: consistently don't use sudo
3623fbb 
Other commands which are executed are also privileged, so using sudo
shouldn't be needed.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @invidian!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-packet 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-packet has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2020
@rawkode
Copy link
Contributor

rawkode commented Dec 15, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@rawkode: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gianarb
Copy link
Contributor

gianarb commented Dec 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020
@gianarb
Copy link
Contributor

gianarb commented Dec 15, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianarb, invidian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit e8d3e39 into kubernetes-sigs:master Dec 15, 2020
@invidian invidian deleted the invidian/remove-sudo-from-templates branch December 15, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianarb gianarb Awaiting requested review from gianarb

@thebsdbox thebsdbox Awaiting requested review from thebsdbox

Assignees

@gianarb gianarb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@invidian @k8s-ci-robot @rawkode @gianarb