New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proper cluster reconcile loop, remove finalizers on delete #26

Merged

gianarb merged 1 commit into v1alpha3 from proper-packetcluster-status

May 6, 2020

Contributor

deitch commented May 6, 2020

Does two things:

for cluster reconcile, be sure to set the status to ready so it can be used
for machine delete, be sure to remove the finalizer once it is deleted


          proper cluster reconcile loop, remove finalizers on delete

fd5a224

deitch requested a review from gianarb

May 6, 2020 12:41

gianarb approved these changes

View reviewed changes

Contributor

gianarb left a comment

I see things coming together!

gianarb merged commit 5134d42 into v1alpha3

gianarb deleted the proper-packetcluster-status branch

May 6, 2020 12:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment