⚠️ CAPI v1 support #307

detiber · 2022-02-07T15:42:00Z

What this PR does / why we need it:

Updates cluster-api-provider-packet to support Cluster API v1 (v1beta1 api types)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #220
Fixes #245

TODO:

Replaces #269 and #289

Blocked on: kubernetes-sigs/cloud-provider-equinix-metal#230, kubernetes-sigs/cloud-provider-equinix-metal#234

davidspek · 2022-03-07T14:03:16Z

@detiber I've been watching this PR for a while now and I'm wondering if I can provide some help to get this ready for merging.

detiber · 2022-03-07T19:40:28Z

@detiber I've been watching this PR for a while now and I'm wondering if I can provide some help to get this ready for merging.

@davidspek Thanks for reaching out. The biggest outstanding item is for getting the changes to cloud-provider-equinix-metal merged and a new release for that published (kubernetes-sigs/cloud-provider-equinix-metal#232, kubernetes-sigs/cloud-provider-equinix-metal#230).

Outside of that, I think the next biggest thing is making sure the documentation is updated, including how to upgrade from v1alpha3/v0.3.x. The big thing to highlight here is that the v1alpha3/v0.3.x multitenancy support (namespaced based) is not supported out of the box with v1beta1/v1+ (https://cluster-api.sigs.k8s.io/developer/providers/v1alpha3-to-v1alpha4.html#multi-tenancy)

We'd also welcome any additional testing/validation that you are willing to do.

davidspek · 2022-03-07T20:06:41Z

@detiber I'll look into this more in a couple days. I was able to get a dev environment setup and deploy about 6 clusters using this branch so it does look like it's working properly.

Another thing I'd like to do is solve the todos for using kube-vip. Should that be a separate PR after this release, or do you think that should be included for this release?

davidspek · 2022-03-08T20:30:39Z

@detiber I've gotten kube-vip integrated and working for HA control planes. There only does seem to be an issue with clusterctl generate cluster that messes up the YAML formatting of the preKubeadmCommands and postKubeadmCommands. For now I'm going to try and find a way around the problem, but it likely needs to be fixed upstream as well.

If I find a way around the formatting issues, do you think the kube-vip integration should be part of this PR?

davidspek · 2022-03-08T21:09:56Z

I've got the formatting issue that occurs when running clusterctl generate cluster now solved as well, so it should be possible to add this to the current PR.

cprivitere · 2022-03-08T22:13:51Z

Hi @davidspek, can you put in a PR against https://github.com/detiber/cluster-api-provider-packet so we can see the changes?

davidspek · 2022-03-08T22:17:05Z

@cprivite Sure, I'll create a PR in tomorrow morning. The changes are actually quite minimal.

davidspek · 2022-03-08T22:47:06Z

@cprivite @detiber I just created the PR quickly before I head off to bed so you can already take a look at the changes.

detiber#65

davidspek · 2022-03-09T11:08:18Z

I've just noticed that the CCM starts trying to assign the control plane EIP to one of the nodes, which it shouldn't do when using kube-vip. I've laid out the issue and possible solutions in kubernetes-sigs/cloud-provider-equinix-metal#230 (comment).

I've updated my PR so that the CCM doesn't take control of the control plane EIP anymore.

- Update dependencies: - GitHub Actions: - Bump actions/checkout from 2.3.5 to 3 - Bump actions/cache from 2 to 3 - bump cobra to v1.4.0 - Bump cluster api to 1.1.3 and bump associated dependencies as a result - Update CPEM deployment to latest - Update calico, use kustomize from upstream source, and override images to use quay.io instead of dockerhub - Remove separate deployment for webhooks - Add configuration for cpem to use host ip for heatlh checks - Add retries into cluster template for installing CPEM - Add upstream e2e tests - Update conformance spec skip serial tests like upstream does - Update ci and build workflows to make better use of caching - Add upgrade and multitenancy documentation Co-authored-by: Chris Privitere <cprivite@users.noreply.github.com> Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>

detiber · 2022-04-01T19:54:49Z

/assign @displague

displague

All these passing tests are a thing of beauty, https://github.com/detiber/cluster-api-provider-packet/runs/5793843612?check_suite_focus=true .

Thanks for your dedication to the project and this effort, @detiber!

This was a massive lift and it's greatly appreciated. 🚀

I left some nitpicks on TODO items, but I don't see why we can't address those (and release notes) post-merge ahead of release.

displague · 2022-04-01T22:15:57Z

.github/workflows/ci.yaml

+  push:
+    branches:
+    - main
+    - capi-v1 # TODO: Used for testing my fork, remove prior to merge


Let's clear out these "prior to merge" todos

displague · 2022-04-01T22:16:29Z

.github/workflows/cleanup.yaml

+name: Cleanup
+on:
+  schedule:
+    - cron: "0 */2 * * *" # TODO: Run every 4 hours to soak test, should be less frequent before merge (weekly/daily/???)


another "before merge" TODO

displague · 2022-04-01T22:26:21Z

/honk

k8s-ci-robot · 2022-04-01T22:26:22Z

@displague:

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

displague · 2022-04-01T22:28:30Z

/approve
/lgtm

practicing for #314

k8s-ci-robot · 2022-04-01T22:28:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, displague

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [detiber]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

displague · 2022-04-01T22:30:44Z

/lgtm

k8s-ci-robot requested review from jacobsmith928 and mrmrcoleman February 7, 2022 15:42

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2022

This was referenced Feb 7, 2022

[WIP] ⚠️ v1alpha4 updates #269

Closed

[WIP] CAPI v1beta1 support #289

Closed

BobyMCbobs mentioned this pull request Feb 10, 2022

Update CAPI version to v1 sharingio/pair#109

Closed

detiber self-assigned this Mar 15, 2022

detiber force-pushed the capi-v1 branch from 7929242 to 85c660c Compare March 22, 2022 19:13

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2022

detiber force-pushed the capi-v1 branch from 2b9b735 to 1a7791c Compare April 1, 2022 19:52

detiber changed the title ~~[WIP] ⚠️ CAPI v1 support~~ ⚠️ CAPI v1 support Apr 1, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2022

k8s-ci-robot assigned displague Apr 1, 2022

displague approved these changes Apr 1, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2022

k8s-ci-robot merged commit 365fddb into kubernetes-sigs:main Apr 1, 2022

cprivitere mentioned this pull request Apr 4, 2022

REQUEST: New membership for cprivitere kubernetes/org#3355

Closed

9 tasks

displague mentioned this pull request Apr 14, 2022

Add ClusterAPI v1.1 support #323

Closed

t-lo mentioned this pull request Jan 4, 2023

packet (Equinix Metal) support flatcar/Flatcar#919

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚠️ CAPI v1 support #307

⚠️ CAPI v1 support #307

detiber commented Feb 7, 2022 •

edited

Loading

davidspek commented Mar 7, 2022

detiber commented Mar 7, 2022

davidspek commented Mar 7, 2022 •

edited

Loading

davidspek commented Mar 8, 2022

davidspek commented Mar 8, 2022

cprivitere commented Mar 8, 2022

davidspek commented Mar 8, 2022

davidspek commented Mar 8, 2022

davidspek commented Mar 9, 2022 •

edited

Loading

detiber commented Apr 1, 2022

displague left a comment •

edited

Loading

displague Apr 1, 2022

displague Apr 1, 2022 •

edited

Loading

displague commented Apr 1, 2022

k8s-ci-robot commented Apr 1, 2022

displague commented Apr 1, 2022 •

edited

Loading

k8s-ci-robot commented Apr 1, 2022

displague commented Apr 1, 2022

⚠️ CAPI v1 support #307

⚠️ CAPI v1 support #307

Conversation

detiber commented Feb 7, 2022 • edited Loading

davidspek commented Mar 7, 2022

detiber commented Mar 7, 2022

davidspek commented Mar 7, 2022 • edited Loading

davidspek commented Mar 8, 2022

davidspek commented Mar 8, 2022

cprivitere commented Mar 8, 2022

davidspek commented Mar 8, 2022

davidspek commented Mar 8, 2022

davidspek commented Mar 9, 2022 • edited Loading

detiber commented Apr 1, 2022

displague left a comment • edited Loading

Choose a reason for hiding this comment

displague Apr 1, 2022

Choose a reason for hiding this comment

displague Apr 1, 2022 • edited Loading

Choose a reason for hiding this comment

displague commented Apr 1, 2022

k8s-ci-robot commented Apr 1, 2022

displague commented Apr 1, 2022 • edited Loading

k8s-ci-robot commented Apr 1, 2022

displague commented Apr 1, 2022

detiber commented Feb 7, 2022 •

edited

Loading

davidspek commented Mar 7, 2022 •

edited

Loading

davidspek commented Mar 9, 2022 •

edited

Loading

displague left a comment •

edited

Loading

displague Apr 1, 2022 •

edited

Loading

displague commented Apr 1, 2022 •

edited

Loading