-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go install script and add kustomize install script #412
Update go install script and add kustomize install script #412
Conversation
|
Welcome @ocobleseqx! |
/easycla |
/lgtm |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: displague, ocobleseqx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Updates scripts/go_install.sh file to use
go install
instead ofgo get
which was deprecated in golang 1.17 and it no longer install packages after 1.18. It is required to execute e2e tests locally with latest go version, and will be required before update the go version in all github actions and other references. Issue #410 contains more information about the kustomize installation changes included in this PR.Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
fixes #410