-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet runs on master #44
kubelet runs on master #44
Conversation
with the userdata currently it place in this PR the master gets a running kubelet. As reported on Jira, the kubelet is not running because we do not install a CNI yet, but this is not crucial at the moment. The userdata has some fixed values that we have to remove, like the ROLE. We will get there moving forward. I would like to fix the certificate issue first
I have a few questions with this.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, really nice tracking all of this down. The only outstanding questions I had were about removing some comments, some typos, and the requeue?
@@ -175,13 +175,13 @@ func (r *PacketMachineReconciler) reconcile(ctx context.Context, machineScope *s | |||
|
|||
if !machineScope.Cluster.Status.InfrastructureReady { | |||
machineScope.Info("Cluster infrastructure is not ready yet") | |||
return ctrl.Result{Requeue: true, RequeueAfter: 30 * time.Second}, nil | |||
return ctrl.Result{}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we no longer requeue? Don't we need to tell it to come back and queue up the request again? Or does the Machine controller change something on the PacketMachine when the cluster is ready? Something has to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied it from aws. It works
} | ||
|
||
// Make sure bootstrap data secret is available and populated. | ||
if machineScope.Machine.Spec.Bootstrap.DataSecretName == nil { | ||
machineScope.Info("Bootstrap data secret is not yet available") | ||
return ctrl.Result{Requeue: true, RequeueAfter: 30 * time.Second}, nil | ||
return ctrl.Result{}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied it from aws. It works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw. But how?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an answer even for the previous code
pkg/cloud/packet/scope/machine.go
Outdated
secret := &corev1.Secret{} | ||
key := types.NamespacedName{Namespace: m.Namespace(), Name: *m.Machine.Spec.Bootstrap.DataSecretName} | ||
if err := m.client.Get(context.TODO(), key, secret); err != nil { | ||
return nil, errors.Wrapf(err, "failed to retrieve bootstrap data secret for AWSMachine %s/%s", m.Namespace(), m.Name()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant "PacketMachine"
with the userdata currently it place in this PR the master gets a
running kubelet.
As reported on Jira, the kubelet is not running because we do not
install a CNI yet, but this is not crucial at the moment.
The userdata has some fixed values that we have to remove, like the
ROLE. We will get there moving forward.
I would like to fix the certificate issue first