-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update example to use MachineDeployment #46
update example to use MachineDeployment #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, but why are we regressing to v1alpha2? These structures are supported in v1alpha3 as far as I know.
templates/cluster-template.yaml
Outdated
@@ -84,114 +84,74 @@ spec: | |||
- "${SSH_KEY}" | |||
tags: [] | |||
--- | |||
apiVersion: cluster.x-k8s.io/v1alpha3 | |||
kind: Machine | |||
apiVersion: cluster.x-k8s.io/v1alpha2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this v1alpha2? Should it not be v1alpha3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo!
templates/cluster-template.yaml
Outdated
bootstrap: | ||
configRef: | ||
name: ${CLUSTER_NAME}-worker-a | ||
apiVersion: bootstrap.cluster.x-k8s.io/v1alpha2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: v1alpha3?
templates/cluster-template.yaml
Outdated
kind: KubeadmConfigTemplate | ||
infrastructureRef: | ||
name: ${CLUSTER_NAME}-worker-a | ||
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here?
The right way to go here is via MachineSet, MachineDeployment. Those are almost the equivalent of ReplicaSet and Deployment for pod. * MachineSet represents an immutable group of Machine * MachineDeployment manage the lifecycle of MachineSet I updated our example to use those for pod rollout. By consequence the example also uses KubeadmConfigTemplate and PacketMachineTemplate Control Plane management will come in another PR.
The right way to go here is via MachineSet, MachineDeployment.
Those are almost the equivalent of ReplicaSet and Deployment for pod.
I updated our example to use those for pod rollout.
By consequence the example also uses KubeadmConfigTemplate and
PacketMachineTemplate
Control Plane management will come in another PR.