Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to github actions #57

Merged
merged 1 commit into from
May 18, 2020
Merged

switch to github actions #57

merged 1 commit into from
May 18, 2020

Conversation

deitch
Copy link
Contributor

@deitch deitch commented May 18, 2020

This does not do anything fancy, doesn't add any new features like goreleaser, or use any special actions. Largely replicates what we did for ccm and csi. The goal is to get us to GH Actions, and then we can iterate on it.

@deitch deitch force-pushed the ghactions branch 5 times, most recently from 93747ad to fa60a99 Compare May 18, 2020 12:33
@deitch deitch requested a review from gianarb May 18, 2020 12:36
@deitch
Copy link
Contributor Author

deitch commented May 18, 2020

@gianarb this does everything the current .drone.yml does. Do not merge it in yet. We need to add the credentials, hopefully later today. Then we can merge it in.

Then you can add a separate release stage. FYI, one of the actions does handle release, so just need to add more or extend it, or even a separate action.

@deitch
Copy link
Contributor Author

deitch commented May 18, 2020

Oh, and CI will fail now. I removed .drone.yml in this PR. Once it is merged in, I can remove the dependency on it.

Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and super fancy work!! 🎉 thanks for doing it!

@deitch
Copy link
Contributor Author

deitch commented May 18, 2020

Ready to be merged @gianarb

@deitch deitch merged commit f338d25 into master May 18, 2020
@deitch deitch deleted the ghactions branch May 18, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants