Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Modify type.go to include shortNames for few Packet CRDs #585

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

bnallapeta
Copy link
Contributor

@bnallapeta bnallapeta commented Apr 18, 2023

What this PR does / why we need it:
This PR adds shortNames to several packet CRDs.

Which issue(s) this PR fixes:
Fixes #421.

Local Run:

# kubectl api-resources | grep -i packet
NAME                              SHORTNAMES   APIVERSION                                NAMESPACED   KIND
packetclusters                    pcl          infrastructure.cluster.x-k8s.io/v1beta1   true         PacketCluster
packetmachines                    pma          infrastructure.cluster.x-k8s.io/v1beta1   true         PacketMachine
packetmachinetemplates            pmt          infrastructure.cluster.x-k8s.io/v1beta1   true         PacketMachineTemplate

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bnallapeta / name: Bharath Nallapeta (1a03ba9)

@k8s-ci-robot
Copy link
Contributor

Welcome @bnallapeta!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-packet 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-packet has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 18, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 18, 2023
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bnallapeta
Copy link
Contributor Author

/test all

@k8s-ci-robot
Copy link
Contributor

@bnallapeta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bnallapeta
Copy link
Contributor Author

bnallapeta commented Apr 19, 2023

@ctreatma Could you drop in an /ok-to-test label so that it triggers the test suite? Thanks.

@ctreatma
Copy link
Contributor

I think @cprivitere will need to approve the test workflows...I haven't earned anyone's trust yet 🤪

@cprivitere
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 20, 2023
@cprivitere
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023
@cprivitere
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bnallapeta, cprivitere, ctreatma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cprivitere cprivitere removed the request for review from deitch April 20, 2023 15:34
@cprivitere
Copy link
Member

/pony

@k8s-ci-robot
Copy link
Contributor

@cprivitere: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cprivitere
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 070ee2c into kubernetes-sigs:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Add shortcuts for packetmachine and packetmachine template.
4 participants