Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix usage of version #63

Merged
merged 1 commit into from
May 18, 2020
Merged

fix usage of version #63

merged 1 commit into from
May 18, 2020

Conversation

deitch
Copy link
Contributor

@deitch deitch commented May 18, 2020

Fixes Makefile in 2 ways:

  • ensures that the URL referenced in clusterctl.yaml for the release points to the correct release file
  • refuses to run if the version is not discoverable

The next fix (which you offered to do @gianarb :-) ) is to:

  • use the most recent tag, not just the one on head
  • if there is no recent tag, just use v.0.0.0

@deitch deitch requested a review from gianarb May 18, 2020 18:42
@gianarb gianarb merged commit 87fb253 into master May 18, 2020
@gianarb gianarb deleted the release-clusterctl branch May 18, 2020 18:49
davidspek pushed a commit to pluralsh/cluster-api-provider-packet that referenced this pull request Mar 8, 2022
@detiber
Merge pull request kubernetes-sigs#63 from cprivite/capi-v1
2fe7fd9 
Update Makefile and conformance spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianarb gianarb gianarb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deitch @gianarb