Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add EMLB deletion #771

Merged
merged 10 commits into from
Jun 18, 2024
Merged

✨ Add EMLB deletion #771

merged 10 commits into from
Jun 18, 2024

Commits on May 30, 2024

  1. feat: delete load balancers when clusters are deleted 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed May 30, 2024
    Configuration menu
    Copy the full SHA
    ed3442f View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. feat: add finalizer code 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f3ee310 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. fix: move from switch to if 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    ba20443 View commit details
    Browse the repository at this point in the history

  2. feat: add emlb deletion to machien controller 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    e61b829 View commit details
    Browse the repository at this point in the history

  3. fix: move forward even though there are errors 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    cebd848 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. chore: remove origin and port deletions as they were unnecessary 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9eb2812 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. refactor: ignore 404 errors while deleting load balancers 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f3215df View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. refactor: take marques suggestion to remove unnecessary get calls 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    70b4b26 View commit details
    Browse the repository at this point in the history

  2. chore(lint): fix lint errors 

    Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
    @cprivitere
    cprivitere committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0817226 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Marques Johansson <mjohansson@equinix.com>
    @cprivitere @displague
    cprivitere and displague authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    53f1647 View commit details
    Browse the repository at this point in the history