-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add EMLB based templates for testing and deployment #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Jun 14, 2024
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jun 14, 2024
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jun 21, 2024
cprivitere
requested review from
displague
and removed request for
deitch and
detiber
June 21, 2024 14:11
…2e tests to reference emlb template Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
* add constants for "KUBE_VIP" and "CPEM" VIPManager IDs * Get the Elastic IP reservation when using Kube-VIP (used to do this previously but it got accidentally removed) Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
cprivitere
force-pushed
the
emlb-templates
branch
from
June 21, 2024 14:16
2d838df
to
6accec5
Compare
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
ctreatma
approved these changes
Jun 25, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, ctreatma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Privitere 23177737+cprivitere@users.noreply.github.com
What this PR does / why we need it:
This template further progresses #693 by adding cluster deployment and e2e testing templates.
The initial EMLB PR provided a provisioning template, but this one is now properly generated via kustomize and created as part of
make generate-templates
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #