🐛 Fix CI Cleanup #776
Merged
🐛 Fix CI Cleanup #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Emlb ci cleanup token fix
k8s-ci-robot
added
cncf-cla: yes
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
displague
reviewed
Jun 27, 2024
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
ctreatma
approved these changes
Jun 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, ctreatma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: #775 added CI cleanup support for Equinix Metal Load Balancer objects but didn't pass along the tokenexchanger needed to authenticate to delete those objects. This PR makes the tokenexchanger a public variable so it can be passed along and passes it to the emlb calls to delete the load balancer objects. While I was in there, I also made the CI Cleanup action runnable on demand which helps with testing and lets us manually run the CI cleanup in case it's necessary in the future.
I could use some confirmation that making TokenExchanger public isn't a big deal.