🌱 Capi 1.7.4 and other cleanup #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
* Bump capi to 1.7.4 * remove leftover testify assert and replace with ginkgo assert * bump equinix-sdk-go to 0.42.0 Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
displague
approved these changes
Jul 10, 2024
| assert.Equal(t, "sample_token", token.AccessToken) | ||
| assert.Equal(t, time.Now().Add(time.Hour).Round(time.Second), token.Expiry.Round(time.Second)) | ||
| g.Expect(token.AccessToken).To(Equal("sample_token")) | ||
| g.Expect(token.Expiry.Round(time.Second)).To(Equal(time.Now().Add(time.Hour).Round(time.Second))) |
There was a problem hiding this comment.
Curious if rounding to minute would alleviate some flakes (wondering how many ticks happen between the token being generated and compared and whether IO (network) is involved)
Code is unchanged, so this is just a nitpic
There was a problem hiding this comment.
It's a unit test against a mock http server, so probably not a big risk, but still a good point.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: