-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Capi 1.7.4 and other cleanup #781
Conversation
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
* Bump capi to 1.7.4 * remove leftover testify assert and replace with ginkgo assert * bump equinix-sdk-go to 0.42.0 Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
assert.Equal(t, "sample_token", token.AccessToken) | ||
assert.Equal(t, time.Now().Add(time.Hour).Round(time.Second), token.Expiry.Round(time.Second)) | ||
g.Expect(token.AccessToken).To(Equal("sample_token")) | ||
g.Expect(token.Expiry.Round(time.Second)).To(Equal(time.Now().Add(time.Hour).Round(time.Second))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious if rounding to minute would alleviate some flakes (wondering how many ticks happen between the token being generated and compared and whether IO (network) is involved)
Code is unchanged, so this is just a nitpic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a unit test against a mock http server, so probably not a big risk, but still a good point.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: