Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install kustomize via hack dir #83

Merged
merged 1 commit into from
May 26, 2020
Merged

install kustomize via hack dir #83

merged 1 commit into from
May 26, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented May 26, 2020

No description provided.

@gianarb gianarb requested a review from deitch May 26, 2020 09:22
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to make it more user-friendly.

TEST_E2E_DIR := test/e2e

# Binaries.
KUSTOMIZE := $(TOOLS_BIN_DIR)/kustomize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a "human-readable" dependency, so it looks something like:

kustomize: $(KUSTOMIZE)
$(KUSTOMIZE): $(TOOLS_DIR)/go.mod # Build kustomize from tools folder.
 	cd $(TOOLS_DIR); go build -tags=tools -o $(BIN_DIR)/kustomize sigs.k8s.io/kustomize/kustomize/v3

and then for the later dependency:

manifest: kustomize semver release-manifests release-clusterctl release-cluster-template

and then we can have a list of tools:

tools: kustomize controller-gen kubebuilder

This makes it easier to read, easier to parse, and one can do:

make kustomize

to ensure it is installed.

@gianarb gianarb requested a review from deitch May 26, 2020 09:28
@gianarb gianarb merged commit 7ca4537 into kubernetes-sigs:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants