-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document migration path from haproxy to kube-vip #1050
document migration path from haproxy to kube-vip #1050
Conversation
5861804
to
d6b1cb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, only few small nits
Signed-off-by: Yassine TIJANI <ytijani@vmware.com> Co-authored-by: Fabrizio Pandini <fabrizio.pandini@gmail.com>
8410749
to
b3cb159
Compare
@fabriziopandini - addressed comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yassine TIJANI ytijani@vmware.com
What this PR does / why we need it: This PR adds steps to migrate from
HAProxyLoadBalancer
to akube-vip
setupWhich issue(s) this PR fixes : Fixes #
Special notes for your reviewer:
Release note: