Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document migration path from haproxy to kube-vip #1050

Merged

Conversation

yastij
Copy link
Member

@yastij yastij commented Nov 4, 2020

Signed-off-by: Yassine TIJANI ytijani@vmware.com

What this PR does / why we need it: This PR adds steps to migrate from HAProxyLoadBalancer to a kube-vip setup

Which issue(s) this PR fixes : Fixes #

Special notes for your reviewer:

Release note:


@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2020
@yastij yastij force-pushed the migration-haproxy-kube-vip branch 2 times, most recently from 5861804 to d6b1cb9 Compare November 5, 2020 11:38
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, only few small nits

docs/migrations.md Outdated Show resolved Hide resolved
docs/migrations.md Outdated Show resolved Hide resolved
docs/migrations.md Outdated Show resolved Hide resolved
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>

Co-authored-by: Fabrizio Pandini <fabrizio.pandini@gmail.com>
@yastij yastij force-pushed the migration-haproxy-kube-vip branch from 8410749 to b3cb159 Compare November 5, 2020 14:22
@yastij
Copy link
Member Author

yastij commented Nov 5, 2020

@fabriziopandini - addressed comments

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
Copy link
Member Author

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 17f647f into kubernetes-sigs:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants