-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Automate GitHub release creation #2050
✨ Automate GitHub release creation #2050
Conversation
06c770c
to
a6c98a3
Compare
a6c98a3
to
78ca5cd
Compare
Test release on my CAPV fork: https://github.com/sbueringer/cluster-api-provider-vsphere/releases/tag/v1.8.0 |
Only remainting task is now waiting for kubernetes-sigs/cluster-api#9018 to be merged and cherry-picked |
78ca5cd
to
d95b903
Compare
@@ -6,20 +6,19 @@ require ( | |||
github.com/joelanford/go-apidiff v0.6.0 | |||
github.com/onsi/ginkgo/v2 v2.11.0 | |||
k8s.io/code-generator v0.27.3 | |||
sigs.k8s.io/cluster-api/hack/tools v0.0.0-20230711141913-5dedc1b4f9d5 | |||
sigs.k8s.io/cluster-api/hack/tools v0.0.0-20230720182410-9c0a017bd4e3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrischdi Let's make sure we bump this to the v1.5.0 commit next week. But I think for now it's fine to change this from the rc.0 commit to the latest commit of the release-1.5 release branch
/retest |
/assign @randomvariable @srm09 @yastij I will cherry-pick this back to all release branches manually. The versions of the relase note tool we use will probably slighty differ but that should be okay. |
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-cluster-api-provider-vsphere-e2e |
/retest |
What this PR does / why we need it:
Implementation of first phase of automated GitHub releases.
Test release on my CAPV fork: https://github.com/sbueringer/cluster-api-provider-vsphere/releases/tag/v1.8.0
Also verified all attached files and they look perfect.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
Part of #2051