Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Automate GitHub release creation #2050

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 20, 2023

What this PR does / why we need it:
Implementation of first phase of automated GitHub releases.

Test release on my CAPV fork: https://github.com/sbueringer/cluster-api-provider-vsphere/releases/tag/v1.8.0
Also verified all attached files and they look perfect.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


Part of #2051

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2023
@k8s-ci-robot k8s-ci-robot requested a review from vrabbi July 20, 2023 13:07
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2023
hack/tools/go.mod Outdated Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-automate-release branch 2 times, most recently from 06c770c to a6c98a3 Compare July 20, 2023 13:55
@sbueringer
Copy link
Member Author

Test release on my CAPV fork: https://github.com/sbueringer/cluster-api-provider-vsphere/releases/tag/v1.8.0
Also verified all attached files and they look perfect.

@sbueringer
Copy link
Member Author

Only remainting task is now waiting for kubernetes-sigs/cluster-api#9018 to be merged and cherry-picked

@@ -6,20 +6,19 @@ require (
github.com/joelanford/go-apidiff v0.6.0
github.com/onsi/ginkgo/v2 v2.11.0
k8s.io/code-generator v0.27.3
sigs.k8s.io/cluster-api/hack/tools v0.0.0-20230711141913-5dedc1b4f9d5
sigs.k8s.io/cluster-api/hack/tools v0.0.0-20230720182410-9c0a017bd4e3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrischdi Let's make sure we bump this to the v1.5.0 commit next week. But I think for now it's fine to change this from the rc.0 commit to the latest commit of the release-1.5 release branch

@sbueringer sbueringer changed the title [WIP] ✨ Automate GitHub release creation ✨ Automate GitHub release creation Jul 20, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

sbueringer commented Jul 20, 2023

/assign @randomvariable @srm09 @yastij
Should be ready for review.

I will cherry-pick this back to all release branches manually. The versions of the relase note tool we use will probably slighty differ but that should be okay.

@sbueringer
Copy link
Member Author

/retest

@randomvariable
Copy link
Member

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2023
@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e

@sbueringer
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit dba258c into kubernetes-sigs:main Jul 21, 2023
14 of 15 checks passed
@sbueringer sbueringer deleted the pr-automate-release branch July 21, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants