Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] 🌱 Bump docker to v24.0.5 #2085

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Manual cherry-pick of #2081.

Release Notes: https://github.com/moby/moby/releases/tag/v24.0.5

This fixes issues similar to kubernetes-sigs/cluster-api#9037 related to using go 1.20.6.

This also should fix our Conformance tests in CI which are currently red, e.g.:

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-provider-vsphere-conformance-release-1-7/1683468651639869440

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Bump docker to v24.0.5

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2023
@randomvariable
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@chrischdi
Copy link
Member Author

/retest

Note: wondering if we should exclude golangci lint from make test when running it as separate action too.

@sbueringer
Copy link
Member

sbueringer commented Jul 25, 2023

/retest

Note: wondering if we should exclude golangci lint from make test when running it as separate action too.

I'll make a note on my side. I think we don't enforce golangci-lint yet for merge (which already was on my list). Once we did this we can drop it from the ProwJob

@chrischdi
Copy link
Member Author

/retest

@chrischdi chrischdi changed the title [release-1.6] 🌱 Bump docker to v24.0.5 [WIP][release-1.6] 🌱 Bump docker to v24.0.5 Jul 25, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2023
@chrischdi chrischdi changed the title [WIP][release-1.6] 🌱 Bump docker to v24.0.5 [release-1.6] 🌱 Bump docker to v24.0.5 Jul 25, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2023
@chrischdi
Copy link
Member Author

Let's wait for #2089

@chrischdi
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit a6b3a5b into kubernetes-sigs:release-1.6 Jul 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants