Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Deprecate v1alpha3 and v1alpha4 apiVersions #2166

Merged
merged 1 commit into from
Aug 8, 2023
Merged

🌱 Deprecate v1alpha3 and v1alpha4 apiVersions #2166

merged 1 commit into from
Aug 8, 2023

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Aug 4, 2023 •
edited

Deprecate v1alpha3 and v1alpha4 apiVersions by:

  1. Adding a Go deprecrated marker to each package and each root API type in packages v1alpha3 and v1alpha4
  2. Add a kubebuilder marker to set deprecated: true on the openAPI definition.

Part of #2165

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 4, 2023
killianmuldoon
killianmuldoon commented Aug 4, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where else this should be documented other than in the release notes for the upcoming release - but happy to add something if someone can point me to the correct spot.

@killianmuldoon killianmuldoon changed the title Deprecate v1alpha3 and v1alpha4 apiVersions [WIP] Deprecate v1alpha3 and v1alpha4 apiVersions Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2023
@killianmuldoon killianmuldoon changed the title [WIP] Deprecate v1alpha3 and v1alpha4 apiVersions [WIP] 🌱 Deprecate v1alpha3 and v1alpha4 apiVersions Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2023
@killianmuldoon killianmuldoon changed the title [WIP] 🌱 Deprecate v1alpha3 and v1alpha4 apiVersions 🌱 Deprecate v1alpha3 and v1alpha4 apiVersions Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 4, 2023
@sbueringer sbueringer added this to the v1.8 milestone Aug 4, 2023
@killianmuldoon killianmuldoon mentioned this pull request Aug 4, 2023
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2023
sbueringer
sbueringer reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits

apis/v1alpha4/doc.go Outdated Show resolved Hide resolved
apis/v1alpha4/vspherefailuredomain_types.go Show resolved Hide resolved
@killianmuldoon
Deprecate v1alpha3 and v1alpha4 apiVersions
2f294c7 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
chrischdi
chrischdi reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4733c26cccd30d973c7d637aa3fe741bb44f4331

@sbueringer
Copy link
Member

/approve

pending CI obviously, but Prow/tide will take care of that

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@sbueringer
Copy link
Member

/retest

@sbueringer sbueringer merged commit 678ac99 into kubernetes-sigs:main Aug 8, 2023
11 checks passed
@killianmuldoon killianmuldoon mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@sbueringer sbueringer sbueringer left review comments

@gab-satchi gab-satchi Awaiting requested review from gab-satchi

@MaxRink MaxRink Awaiting requested review from MaxRink

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@killianmuldoon @k8s-ci-robot @sbueringer @chrischdi