-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Deprecate v1alpha3 and v1alpha4 apiVersions #2166
🌱 Deprecate v1alpha3 and v1alpha4 apiVersions #2166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where else this should be documented other than in the release notes for the upcoming release - but happy to add something if someone can point me to the correct spot.
5d138ea
to
647b003
Compare
647b003
to
87eac3a
Compare
87eac3a
to
794d319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits
794d319
to
6e1d718
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
6e1d718
to
2f294c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 4733c26cccd30d973c7d637aa3fe741bb44f4331
|
/approve pending CI obviously, but Prow/tide will take care of that |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Deprecate v1alpha3 and v1alpha4 apiVersions by:
v1alpha3
andv1alpha4
deprecated: true
on the openAPI definition.Part of #2165