🌱 Add ownerReference resilience test

[killianmuldoon]

Add ownerReference validation to CAPV for the following types in the Cluster and ClusterClass tests:

• vSphereClusterKind
• vSphereClusterTemplateKind
• vSphereMachineKind
• vSphereMachineTemplateKind
• vSphereVMKind
• vSphereClusterIdentity
• vSphereDeploymentZone
• vSphereFailureDomain

The validations - similar to those in CAPI - assert that ownerReferences are re-reconciled if removed and also check that ownerReference apiVersions are always updated to the latest version.

Part of #2075

[killianmuldoon]

/retest

[killianmuldoon]

This error isn't happening for me locally - but it looks like a bug on the CAPI side from a ClusterResourceSetBinding with multiple ownerReferences - good we caught that here. Will bring it up over at the CAPI repo.

/hold
Until this is fixed in core CAPI.

[killianmuldoon]

/retest

[killianmuldoon]

/hold cancel

The ClusterResourceSet error was down to a race condition. I've update the code to ensure the CRS is reconciled before running the ownerReference check.

[sbueringer]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 6714c6928afd71e4e1ecd7a96027146901b61061

[sbueringer]

@killianmuldoon You probably want to squash

[chrischdi]

small nit

/lgtm

[k8s-ci-robot]

@killianmuldoon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-vsphere-e2e-main-oldpreset	7b338f6	link	true	/test pull-cluster-api-provider-vsphere-e2e-main-oldpreset

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sbueringer]

Thank you very much!! Nice work

/lgtm
/approve

Now onto manual cherry-picking I guess :D (or maybe git can deal with this delta)

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ed69c492a5e4bb6ce403c50a1d8565a9f0e03124

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrischdi]

Note: there is still a hold on this PR.

[killianmuldoon]

/hold cancel

[k8s-infra-cherrypick-robot]

@sbueringer: #2209 failed to apply on top of branch "release-1.8":

Applying: Add ownerReference resilience test
.git/rebase-apply/patch:632: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	Makefile
M	controllers/vspherecluster_reconciler.go
M	controllers/vsphereclusteridentity_controller.go
M	controllers/vspheredeploymentzone_controller.go
M	controllers/vspheredeploymentzone_controller_domain.go
M	controllers/vspheremachine_controller.go
M	pkg/identity/identity.go
M	test/e2e/README.md
M	test/e2e/capv_quick_start_test.go
M	test/e2e/config/vsphere-ci.yaml
M	test/e2e/config/vsphere-dev.yaml
M	test/integration/integration-dev.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/integration/integration-dev.yaml
Removing test/e2e/ignition_test.go
Auto-merging test/e2e/config/vsphere-dev.yaml
Auto-merging test/e2e/config/vsphere-ci.yaml
CONFLICT (modify/delete): test/e2e/capv_quick_start_test.go deleted in Add ownerReference resilience test and modified in HEAD. Version HEAD of test/e2e/capv_quick_start_test.go left in tree.
Auto-merging test/e2e/README.md
Auto-merging pkg/identity/identity.go
Auto-merging controllers/vspheremachine_controller.go
CONFLICT (content): Merge conflict in controllers/vspheremachine_controller.go
Auto-merging controllers/vspheredeploymentzone_controller_domain.go
CONFLICT (content): Merge conflict in controllers/vspheredeploymentzone_controller_domain.go
Auto-merging controllers/vspheredeploymentzone_controller.go
CONFLICT (content): Merge conflict in controllers/vspheredeploymentzone_controller.go
Auto-merging controllers/vsphereclusteridentity_controller.go
Auto-merging controllers/vspherecluster_reconciler.go
CONFLICT (content): Merge conflict in controllers/vspherecluster_reconciler.go
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add ownerReference resilience test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: #2209 failed to apply on top of branch "release-1.7":

Applying: Add ownerReference resilience test
.git/rebase-apply/patch:632: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	Makefile
M	controllers/vspherecluster_reconciler.go
M	controllers/vsphereclusteridentity_controller.go
M	controllers/vspheredeploymentzone_controller.go
M	controllers/vspheredeploymentzone_controller_domain.go
M	controllers/vspheremachine_controller.go
M	pkg/identity/identity.go
M	test/e2e/README.md
M	test/e2e/capv_quick_start_test.go
M	test/e2e/config/vsphere-ci.yaml
M	test/e2e/config/vsphere-dev.yaml
M	test/integration/integration-dev.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/integration/integration-dev.yaml
CONFLICT (content): Merge conflict in test/integration/integration-dev.yaml
Removing test/e2e/ignition_test.go
Auto-merging test/e2e/config/vsphere-dev.yaml
CONFLICT (content): Merge conflict in test/e2e/config/vsphere-dev.yaml
Auto-merging test/e2e/config/vsphere-ci.yaml
CONFLICT (content): Merge conflict in test/e2e/config/vsphere-ci.yaml
CONFLICT (modify/delete): test/e2e/capv_quick_start_test.go deleted in Add ownerReference resilience test and modified in HEAD. Version HEAD of test/e2e/capv_quick_start_test.go left in tree.
Auto-merging test/e2e/README.md
Auto-merging pkg/identity/identity.go
Auto-merging controllers/vspheremachine_controller.go
CONFLICT (content): Merge conflict in controllers/vspheremachine_controller.go
Auto-merging controllers/vspheredeploymentzone_controller_domain.go
CONFLICT (content): Merge conflict in controllers/vspheredeploymentzone_controller_domain.go
Auto-merging controllers/vspheredeploymentzone_controller.go
CONFLICT (content): Merge conflict in controllers/vspheredeploymentzone_controller.go
Auto-merging controllers/vsphereclusteridentity_controller.go
Auto-merging controllers/vspherecluster_reconciler.go
CONFLICT (content): Merge conflict in controllers/vspherecluster_reconciler.go
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add ownerReference resilience test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.