🌱 Remove direct dependency to github.com/hashicorp/go-version #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-rebase
chrischdi
force-pushed
the
pr-remove-hashicorp-version
branch
from
d195041
to
45df18c
Compare
k8s-ci-robot
removed
the
needs-rebase
chrischdi
changed the title
chrischdi
force-pushed
the
pr-remove-hashicorp-version
branch
from
45df18c
to
c7e771f
Compare
chrischdi
force-pushed
the
pr-remove-hashicorp-version
branch
from
c7e771f
to
e2acda8
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 971d6ab0188e4e973f089c01d5d6b5f7a035ec0d
|
|
/retest |
|
Thx! Especially for adding the unit test coverage /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes direct dependency on
github.com/hashicorp/go-versionby replacing usage bygit.luolix.top/blang/semver/v4(which is already a transitive dependency).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #2213