-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove direct dependency to github.com/hashicorp/go-version #2219
🌱 Remove direct dependency to github.com/hashicorp/go-version #2219
Conversation
d195041
to
45df18c
Compare
45df18c
to
c7e771f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just one tiny nit
c7e771f
to
e2acda8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 971d6ab0188e4e973f089c01d5d6b5f7a035ec0d
|
/retest |
Thx! Especially for adding the unit test coverage /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Removes direct dependency on
github.com/hashicorp/go-version
by replacing usage bygit.luolix.top/blang/semver/v4
(which is already a transitive dependency).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #2213