-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 github: add workflow to auto-approve golangci-lint if ok-to-test label is set #2255
🌱 github: add workflow to auto-approve golangci-lint if ok-to-test label is set #2255
Conversation
/hold until kubernetes-sigs/cluster-api#9244 is merged |
nit: Let's say merged and verified that it actually works :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for me in the CAPI implementation at kubernetes-sigs/cluster-api#9251
Thanks for tackling this @chrischdi!
/lgtm
/approve
/hold
(for someone else to validate if they want)
LGTM label has been added. Git tree hash: 72a71a84914b634be5b0b8e0d98addb42a5d622d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Perfect! Thx for confirming /lgtm |
What this PR does / why we need it:
Manual cross-repo cherry-pick of
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #