-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 github: add edited and reopened as triggers for the GH workflow approval #2268
🌱 github: add edited and reopened as triggers for the GH workflow approval #2268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we wait to confirm the fix works on CAPI first? or are we confident this works as expected?
I verified that it works. The important point is to have the same triggers as the linter action to not hit the same case. And they are now the same except:
|
/lgtm It makes sense to me - the existing action pretty much works except for not being triggered on updates. |
LGTM label has been added. Git tree hash:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…flow-approval 🌱 github: add edited and reopened as triggers for the GH workflow approval
What this PR does / why we need it:
Adds the types
edited
andreopened
to the triggers for thePR approve GH Workflows
action.Before this PR the golangci-lint action could have been triggered by the
edited
orreopened
actions.The approval workflow would not get triggered in that case and did not approve the linter.
Cross-repo cherry-pick of kubernetes-sigs/cluster-api#9259
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #