🌱 Add license scan for pull requests #2299
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
There was a problem hiding this comment.
/hold
Ensure the PR over on the CAPI repo is merged before this one to avoid parallel changes. kubernetes-sigs/cluster-api#9184
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e1604cdbde0497b95730cb2f2c86a5a3fffa86ac
|
k8s-ci-robot
added
the
approved
| TRIVY_OS="macOS" | ||
| fi | ||
|
|
||
| VERSION=${1} | ||
| GO_ARCH="$(go env GOARCH)" |
There was a problem hiding this comment.
Interesting that we don't have this line in core CAPI and probably just assume that GOARCH is set?
Maybe something to fix in core CAPI? (@killianmuldoon)
There was a problem hiding this comment.
The GO_ARCH here is only used to give the resulting image a name - I'm not sure if it's used for anything else at this point - the ensure-trivy script sets its own GO_ARCH.
Maybe it's a good idea to just remove this here?
There was a problem hiding this comment.
I think it's not used to give it a name, it's used to match the name that is used by make docker-build.
I think if we drop this line we either:
- have to pass GO_ARCH into the script
- have to find another way to match it correctly (I guess GOARCH might be different on macOS vs Linux (?))
I would avoid implicitly depending on an env variable being exported by someone calling that script (which I think is what is happening in core CAPI now). (Because this makes it harder to call the script standalone and just a bit too magical/implicit for my taste)
There was a problem hiding this comment.
You're right - I'll do a PR into CAPI to make them consistent and make CAPI's use of the GO_ARCH more explicit.
|
Thx! Just one nit for core CAPI (also commented on the core CAPI PR) /approve |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds a licence scan inline with what is currently being added in the core Cluster API repo with kubernetes-sigs/cluster-api#9184
Part of kubernetes-sigs/cluster-api#9184