Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 config: add metrics configuration for kube-state-metrics #2345

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

This PR adds a custom resource config for kube-state-metrics to scrape metrics via kube-state-metrics from the CAPV resources.

This could be used together with kubernetes-sigs/cluster-api#9390 and the following configuration in tilt-settings.yaml:

deploy_kustomizations:
  kube-state-metrics-custom-resource-capv: ../cluster-api-provider-vsphere/config/metrics

Note: depends on the path to be correct here.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-e2e-main-oldpreset da4cdff link true /test pull-cluster-api-provider-vsphere-e2e-main-oldpreset

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (f2d4b7d) 50.06% compared to head (0b37814) 50.13%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2345      +/-   ##
==========================================
+ Coverage   50.06%   50.13%   +0.06%     
==========================================
  Files          87       87              
  Lines        8041     8041              
==========================================
+ Hits         4026     4031       +5     
+ Misses       3685     3682       -3     
+ Partials      330      328       -2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbueringer
Copy link
Member

Thank you!!

Fine to merge for me as is

/lgtm
/approve

/hold
(up to you)

Would be good to change the omitempty thing in the gentool so that our final configuration won't contain the unnecessary zero values. But definitely fine to merge for me as is

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b92dc5c9377d65e8ce86d258af5b09d83809138f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@chrischdi
Copy link
Member Author

Thank you!!

Fine to merge for me as is

/lgtm /approve

/hold (up to you)

Would be good to change the omitempty thing in the gentool so that our final configuration won't contain the unnecessary zero values. But definitely fine to merge for me as is

This omitempty part is not on the gentool side, its the kube-state-metrics config struct itself. But yeah, I agree.

@chrischdi
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2023
@sbueringer
Copy link
Member

This omitempty part is not on the gentool side, its the kube-state-metrics config struct itself. But yeah, I agree.

Ah good info and yeah makes sense.

@k8s-ci-robot k8s-ci-robot merged commit a5955a4 into kubernetes-sigs:main Sep 12, 2023
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 12, 2023
@chrischdi chrischdi deleted the pr-initial-crd-metrics branch September 13, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants