-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 config: add metrics configuration for kube-state-metrics #2345
🌱 config: add metrics configuration for kube-state-metrics #2345
Conversation
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
==========================================
+ Coverage 50.06% 50.13% +0.06%
==========================================
Files 87 87
Lines 8041 8041
==========================================
+ Hits 4026 4031 +5
+ Misses 3685 3682 -3
+ Partials 330 328 -2 ☔ View full report in Codecov by Sentry. |
da4cdff
to
0b37814
Compare
Thank you!! Fine to merge for me as is /lgtm /hold Would be good to change the omitempty thing in the gentool so that our final configuration won't contain the unnecessary zero values. But definitely fine to merge for me as is |
LGTM label has been added. Git tree hash: b92dc5c9377d65e8ce86d258af5b09d83809138f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This omitempty part is not on the gentool side, its the kube-state-metrics config struct itself. But yeah, I agree. |
/hold cancel |
Ah good info and yeah makes sense. |
What this PR does / why we need it:
This PR adds a custom resource config for kube-state-metrics to scrape metrics via kube-state-metrics from the CAPV resources.
This could be used together with kubernetes-sigs/cluster-api#9390 and the following configuration in
tilt-settings.yaml
:Note: depends on the path to be correct here.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #