-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Handle missing VSphereFailureDomain on VSphereDeploymentZone deletion #2351
🐛 Handle missing VSphereFailureDomain on VSphereDeploymentZone deletion #2351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherry-pick release-1.8
/cherry-pick release-1.7 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7eb3f77
to
c6be22c
Compare
/cherry-pick release-1.8 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2351 +/- ##
==========================================
+ Coverage 60.74% 60.81% +0.07%
==========================================
Files 164 164
Lines 9473 9475 +2
==========================================
+ Hits 5754 5762 +8
+ Misses 3301 3297 -4
+ Partials 418 416 -2
☔ View full report in Codecov by Sentry. |
🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: a0e62a3ae7aeb48672c0b95c8e63ce7d08f94ec3
|
/approve /hold if others want to review, feel free to unhold |
Would it be feasible to add unit tests for this controller? (maybe as a follow-up) |
c6be22c
to
a14a0fc
Compare
Thank you! /lgtm /assign @chrischdi |
LGTM label has been added. Git tree hash: 7d2b82824737ae303b4f6b9d615170b02bd124ae
|
/hold Turns out I can't cancel approval from others :) (which makes sense) @chrischdi PTAL before merge |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
8f80718
to
71c9d67
Compare
/hold For squash |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
71c9d67
to
448c4c4
Compare
@killianmuldoon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@chrischdi would be good to get some eyes on this when you have time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional nit
/lgtm
LGTM label has been added. Git tree hash: e8f95014558b6e96f245050bee15f80bedcc2ef1
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@killianmuldoon: #2351 failed to apply on top of branch "release-1.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: #2351 failed to apply on top of branch "release-1.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Not going to be able to cherry-pick this one the way it turned out - given the context changes. |
Reorder the reconcile function of the VSphereDeploymentZone in order to ensure deletion can proceed even if the failureDomain does not exist.