🌱 Improve logging for vspherevm_controller & vspherevm_ipaddress_reconciler

[adityabhatia]

What this PR does / why we need it:
This improves logging in vspherevm_controller & vspherevm_ipaddress_reconciler by using the logger from passed context and removing ControllerContext types.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #2076

[k8s-ci-robot]

Hi @adityabhatia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhanggbj]

/ok-to-test

[codecov]

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (d7b0830) 63.67% compared to head (7cd707b) 63.72%.
Report is 16 commits behind head on main.

Files	Patch %	Lines
controllers/vspherevm_controller.go	75.51%	12 Missing ⚠️
controllers/vspherevm_ipaddress_reconciler.go	60.00%	4 Missing ⚠️
pkg/context/fake/fake_vm_context.go	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2484      +/-   ##
==========================================
+ Coverage   63.67%   63.72%   +0.05%     
==========================================
  Files         123      123              
  Lines        8773     8758      -15     
==========================================
- Hits         5586     5581       -5     
+ Misses       2773     2763      -10     
  Partials      414      414              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[killianmuldoon]

Just a small nit around the naming of the logger.

Thanks for this!

[killianmuldoon]

/test pull-cluster-api-provider-vsphere-e2e-full-main

[adityabhatia]

Just a small nit around the naming of the logger.

Thanks for this!

Now there are only 5 other occurrences left across 3 files in the repo.

[adityabhatia]

/retest

[sbueringer]

Thank you!!

/lgtm
/approve

merge pending retest after VMC is fixed (I'll hope that is soon :))

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 09616ae32adc53ccdcfc7b516a13bd690bee5445

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/retest

[k8s-ci-robot]

@adityabhatia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-vsphere-apidiff-main	7cd707b	link	false	/test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.