Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Set InternalDNS address for machines #2529

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

damdo
Copy link
Member

@damdo damdo commented Dec 5, 2023

What this PR does / why we need it:
Currently, CAPV doesn't set an internal dns address for its machines as other providers do. We would ideally want to set this value to the virtual machine's name, so we know that this address can be resolvable.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2013

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da206f1) 63.56% compared to head (d8db2a2) 63.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2529      +/-   ##
==========================================
+ Coverage   63.56%   63.78%   +0.22%     
==========================================
  Files         123      123              
  Lines        8786     8790       +4     
==========================================
+ Hits         5585     5607      +22     
+ Misses       2779     2759      -20     
- Partials      422      424       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi
Copy link
Member

There's already #2513 ,

Did you have a chat with @odvarkadaniel ?

@chrischdi
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@damdo
Copy link
Member Author

damdo commented Dec 5, 2023

Hey @chrischdi
Daniel was on my team but changed teams recently, so I'm taking his work on now.
I've just created a separate PR because it's easier for me to manage this going forward.
We can close #2513 now

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign sbueringer

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 184e37b7c180ece9f59f2bebf4c34365af8aad5c

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@damdo
Copy link
Member Author

damdo commented Dec 5, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8293fe5 into kubernetes-sigs:main Dec 5, 2023
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guestinfo.hostname field in vCenter not set when using ignition for VMs
5 participants