-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Set InternalDNS address for machines #2529
✨ Set InternalDNS address for machines #2529
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
==========================================
+ Coverage 63.56% 63.78% +0.22%
==========================================
Files 123 123
Lines 8786 8790 +4
==========================================
+ Hits 5585 5607 +22
+ Misses 2779 2759 -20
- Partials 422 424 +2 ☔ View full report in Codecov by Sentry. |
There's already #2513 , Did you have a chat with @odvarkadaniel ? |
/hold |
Hey @chrischdi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign sbueringer
LGTM label has been added. Git tree hash: 184e37b7c180ece9f59f2bebf4c34365af8aad5c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What this PR does / why we need it:
Currently, CAPV doesn't set an internal dns address for its machines as other providers do. We would ideally want to set this value to the virtual machine's name, so we know that this address can be resolvable.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2013