Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add generate-test-infra-prowjobs makefile target and update docs #2630

Merged
merged 1 commit into from
Jan 19, 2024
Merged

🌱 Add generate-test-infra-prowjobs makefile target and update docs #2630

merged 1 commit into from
Jan 19, 2024

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Jan 18, 2024 •
edited

What this PR does / why we need it:

Depends on:

Related to:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6226a7) 64.83% compared to head (5b7c3b3) 64.96%.
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2630      +/-   ##
==========================================
+ Coverage   64.83%   64.96%   +0.12%     
==========================================
  Files         118      118              
  Lines        8580     8580              
==========================================
+ Hits         5563     5574      +11     
+ Misses       2588     2582       -6     
+ Partials      429      424       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fabriziopandini
fabriziopandini reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit, otherwise lgtm

Makefile Outdated Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-generate-prowjobs-makefile-and-docs branch 2 times, most recently from 739e251 to 1b421f8 Compare January 18, 2024 14:59
@chrischdi
Copy link
Member Author

/hold

Waiting for kubernetes-sigs/cluster-api#10022 to merge to bump capi tools in makefile

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 38e42b525f0870ff8e378e1b7bda6cdccd17c7fc

@sbueringer
Copy link
Member

Perfect, thx!

/approve

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 19, 2024
@sbueringer
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2024
@sbueringer
Copy link
Member

sbueringer commented Jan 19, 2024 •
edited

@chrischdi Not sure if #2630 (comment) still applies

(EDIT: looks like it does)

@chrischdi chrischdi force-pushed the pr-generate-prowjobs-makefile-and-docs branch from 1b421f8 to 5b7c3b3 Compare January 19, 2024 10:24
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2024
@chrischdi
Copy link
Member Author

Thanks for the pointer, now its good 👍

@sbueringer
Copy link
Member

Yeah my bad, I almost missed it. I should read hold comments before removing hold :)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a4f6b01ed883d55f3f7bd9e20a7e1f01525acdb8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit e0dc2ae into kubernetes-sigs:main Jan 19, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Jan 19, 2024
@chrischdi chrischdi deleted the pr-generate-prowjobs-makefile-and-docs branch January 19, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srm09 srm09 Awaiting requested review from srm09

@yastij yastij Awaiting requested review from yastij

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrischdi @fabriziopandini @k8s-ci-robot @sbueringer