🌱 Refactor test setup #2662
🌱 Refactor test setup #2662
Conversation
k8s-ci-robot
added
cncf-cla: yes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2662 +/- ##
==========================================
- Coverage 64.79% 64.77% -0.02%
==========================================
Files 118 118
Lines 8580 8580
==========================================
- Hits 5559 5558 -1
+ Misses 2593 2592 -1
- Partials 428 430 +2 ☔ View full report in Codecov by Sentry. |
fabriziopandini
force-pushed
the
refactor-test-setup
branch
6 times, most recently
from
2e90687
to
b8519a5
Compare
|
/test |
|
@fabriziopandini: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-vsphere-e2e-full-main |
|
lgtm + stefans nits :-) |
fabriziopandini
force-pushed
the
refactor-test-setup
branch
from
b8519a5
to
298120c
Compare
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 48e69e692d17b12797b451b1d7153dce6c17638e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR refactors a little bit changes recently introduced by #2612, by introducing a single Setup function that claims IP before each test.
This single function (as well as some small refactors) will simplify the implementation for the support of legacy/supervisor and vCenter/vcsim test variants