-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 controllers/vmware fix test to not contain data race #2672
🐛 controllers/vmware fix test to not contain data race #2672
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
==========================================
+ Coverage 64.77% 64.91% +0.13%
==========================================
Files 118 118
Lines 8580 8580
==========================================
+ Hits 5558 5570 +12
+ Misses 2594 2583 -11
+ Partials 428 427 -1 ☔ View full report in Codecov by Sentry. |
/retest |
Thx! /lgtm |
LGTM label has been added. Git tree hash: 4343a6c60e0d686bc3eb0faa87808027504398ec
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This still happens on older release branches: /cherry-pick release-1.9 |
/cherry-pick release-1.8 |
/cherry-pick release-1.7 |
/cherry-pick release-1.6 |
@chrischdi: #2672 failed to apply on top of branch "release-1.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chrischdi: #2672 failed to apply on top of branch "release-1.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chrischdi: new pull request created: #2760 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chrischdi: #2672 failed to apply on top of branch "release-1.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Fixes the error
fatal error: concurrent map read and map write
by not re-usingscheme.Scheme
but using our ownruntime.Scheme
instead.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2325