Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Git ignore config-overrides #2685

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This is a follow-up of #2673 ensuring that the config-overrides files, which is expected to contain potentially sensitive information about the user's vCenter is ignored by git.

Instead, we are providing a config-overrides example the users can start from.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2024
@fabriziopandini fabriziopandini changed the title 🌱 Rename config-overrides 🌱 Git ignore config-overrides Feb 1, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 974dfc59e324ce3721a0985aa509c3ff00557ad5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cafb71f) 65.02% compared to head (e8b9db7) 64.82%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
- Coverage   65.02%   64.82%   -0.21%     
==========================================
  Files         118      118              
  Lines        8593     8593              
==========================================
- Hits         5588     5570      -18     
- Misses       2581     2595      +14     
- Partials      424      428       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot merged commit 187cd63 into kubernetes-sigs:main Feb 1, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Feb 1, 2024
@fabriziopandini fabriziopandini deleted the rename-config-overrides branch February 24, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants