-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Restore v1alpha3/v1alpha4 conversion to fix SSA issue #2739
🐛 Restore v1alpha3/v1alpha4 conversion to fix SSA issue #2739
Conversation
/test ? |
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-vsphere-e2e-main |
833e81c
to
3299c63
Compare
3299c63
to
9a0f13d
Compare
/test pull-cluster-api-provider-vsphere-e2e-main |
Tested the following locally:
So I would conclude that conversion works again and we can handle v1alpha3 entries in managedFields. Additionally we have conversion fuzz-tests for all apiVersions now. |
/lgtm /hold Do we need an issue to track again the final removal? (maybe when only k8s versions are supported which have the k/k fix) |
LGTM label has been added. Git tree hash: 19450088d543b9505cdf9589d94ba1b41fa48be6
|
/test pull-cluster-api-provider-vsphere-e2e-main |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
…linter findings Signed-off-by: Stefan Büringer buringerst@vmware.com
9a0f13d
to
f16d0be
Compare
/test pull-cluster-api-provider-vsphere-e2e-blocking-main |
/retest /lgtm |
LGTM label has been added. Git tree hash: 4ffb1f835f485d4108fba305cb8dfca0ba3dd847
|
What this PR does / why we need it:
For more details see the corresponding issue in core CAPI: kubernetes-sigs/cluster-api#10147
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #