Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 docs: document tagging the test go module #2761

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

We added a go module in test since v1.9. We also should add tags for the test module.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.10%. Comparing base (97737a0) to head (80666b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2761      +/-   ##
==========================================
+ Coverage   64.05%   64.10%   +0.05%     
==========================================
  Files         160      160              
  Lines        9345     9345              
==========================================
+ Hits         5986     5991       +5     
+ Misses       2903     2899       -4     
+ Partials      456      455       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi
Copy link
Member Author

/assign fabriziopandini

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f1d6934a450625ee3bff22756e5c5398e2200794

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit cd8889a into kubernetes-sigs:main Feb 23, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Feb 23, 2024
@chrischdi
Copy link
Member Author

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot

@chrischdi: new pull request created: #2881

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

I don't mind but just wanted to say that we don't have a book in CAPV and we also probably don't want to keep the release tasks doc up-to-date on all active release branches

@chrischdi
Copy link
Member Author

I wanted to bubble up the release tasks, because the test tag was already forgotten for the last release (v1.9.2).

@sbueringer
Copy link
Member

sbueringer commented Apr 5, 2024

Yup good point. But don't we have the problem for all release branches. And also in general if we rely on release-tasks.md being up-to-date on all branches?

(but definitely fine, this also might be a special case)

@chrischdi
Copy link
Member Author

Yup good point. But don't we have the problem for all release branches. And also in general if we rely on release-tasks.md being up-to-date on all branches?

(but definitely fine, this also might be a special case)

Ack, this special case was just the release-1.9 branch did lack this information forever, and I usually copy the tag + push commands from the branch so I don't miss the test tag / leave it out :-)

@sbueringer
Copy link
Member

sbueringer commented Apr 5, 2024

All good! If you tend to do the same for other branches, let's cherry-pick this further :)
(I don't remember if we wanted to do this for older branches & when we introduced the test module)

@chrischdi
Copy link
Member Author

No need to, the module was introduced in v1.9 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants