Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Implement E2E test for vcsim in govmomi mode #2767

Merged
merged 1 commit into from
Mar 4, 2024
Merged

🌱 Implement E2E test for vcsim in govmomi mode #2767

merged 1 commit into from
Mar 4, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Add E2E test for vcsim in govmomi mode + one step closer to test supervisor mode

@fabriziopandini fabriziopandini changed the title 🌱 [WIP] Vcsim e2e 🌱 [WIP] [Do not review] Vcsim e2e Feb 26, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 26, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.93%. Comparing base (180146b) to head (2a8ecbe).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2767      +/-   ##
==========================================
- Coverage   64.01%   63.93%   -0.09%     
==========================================
  Files         160      160              
  Lines        9345     9360      +15     
==========================================
+ Hits         5982     5984       +2     
- Misses       2906     2916      +10     
- Partials      457      460       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziopandini
Copy link
Member Author

/test

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-main
  • /test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main
  • /test pull-cluster-api-provider-vsphere-test-integration-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-blocking-main
  • pull-cluster-api-provider-vsphere-test-integration-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main
/test pull-cluster-api-provider-vsphere-test-integration-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-blocking-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-blocking-main

1 similar comment
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-blocking-main

@fabriziopandini fabriziopandini changed the title 🌱 [WIP] [Do not review] Vcsim e2e 🌱 [WIP] Vcsim e2e Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2024
chrischdi
chrischdi reviewed Mar 1, 2024
View reviewed changes
hack/e2e.sh Outdated Show resolved Hide resolved
test/framework/ip/vcsim.go Outdated Show resolved Hide resolved
test/infrastructure/tmp-to-be-deleted/server/listener.go Outdated Show resolved Hide resolved
test/infrastructure/vcsim/controllers/virtualmachine_controller.go Outdated Show resolved Hide resolved
test/e2e/quick_start_test.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2024
@fabriziopandini fabriziopandini mentioned this pull request Mar 1, 2024
Merged
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-blocking-main

@fabriziopandini fabriziopandini changed the title 🌱 [WIP] Vcsim e2e 🌱 Implement E2E test for vcsim in govmomi mode Mar 1, 2024
chrischdi
chrischdi reviewed Mar 4, 2024
View reviewed changes
test/e2e/e2e_suite_test.go Show resolved Hide resolved
test/e2e/e2e_suite_test.go
Comment on lines +279 to +282
// Add config overrides + drop vcsim relates provider/image if not necessary.
amendE2EConfig()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch that we need this here too :-) 👍

test/e2e/e2e_suite_test.go
return sc
}

func amendE2EConfig() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: we could integrate this into vsphereframework.LoadE2EConfig, but ok to keep as is :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this here for now, it depends on global variables

@chrischdi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d101919304f54dd0fc0481f10455777f5038d6ae

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit a80aacd into kubernetes-sigs:main Mar 4, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Mar 4, 2024
@fabriziopandini fabriziopandini deleted the vcsim-e2e branch March 25, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@yastij yastij Awaiting requested review from yastij

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @k8s-ci-robot @chrischdi