🐛 Fixes issue with NCP versioning while using the semver package

[gab-satchi]

What this PR does / why we need it:
NSX releases can have more than 3 segments. They frequently have 4. This causes an issue when there's an attempt to parse it with the semver package.

In this PR, if a version with 4 segments is found, it will trim the last segment before parsing it as a semver. The codepath is only there to check that the version is >= 3.0.1 and < 3.1.0 so precision isn't lost by trimming down to 3 segments.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: gab-satchi / name: Gab Satchi (7828bdc)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.22%. Comparing base (a80aacd) to head (7828bdc).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2796      +/-   ##
==========================================
+ Coverage   64.13%   64.22%   +0.09%     
==========================================
  Files         160      160              
  Lines        9360     9367       +7     
==========================================
+ Hits         6003     6016      +13     
+ Misses       2902     2898       -4     
+ Partials      455      453       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhanggbj]

Thanks for fixing it!
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 06b9b171ec8018aff0329725e7b8e7d6e0066656

[chrischdi]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 3ac90420cb6757706c685ed7cd1205576d0b58c0

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrischdi]

/cherry-pick release-1.9

[k8s-infra-cherrypick-robot]

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@chrischdi: new pull request created: #2797

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.